🐛 Clean restmapper cache if a version is notFound#2663
Conversation
This avoids: - Extra calls to https://host/apis/<group>/<version> when a version seen before and cached in apiGroups is deleted or marked as not served. - Returnning a valid mapping for a cached version that is deleted or not served anymore.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/retest |
|
Thank you very much! /lgtm /assign @alvaroaleman @vincepri |
k8s-ci-robot
added
the
lgtm
sbueringer
added
the
tide/merge-method-squash
vincepri
left a comment
vincepri
left a comment
There was a problem hiding this comment.
one minor comment, rest lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
As mentioned in the issue. We would like to backport this into v0.17 and v0.16. v0.16 requires a manual backport. Let's see if we get lucky with 0.17 /cherry-pick release-0.17 |
|
@sbueringer: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-0.17 |
|
@sbueringer: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Pushed the release-0.17 branch based on v0.17.0 |
|
/cherry-pick release-0.17 |
|
@sbueringer: new pull request created: #2676 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
This avoids:
https://host/apis/<group>/<version>when a version seen before and cached in apiGroups is deleted or marked as not served.I would like backport this fix to v0.16 (or at version of it since it won't apply cleanly). It would help us solve this issue in cluster-api kubernetes-sigs/cluster-api#10032